Serde test for JdbcExtractionNamespace. #6186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihoonson
approved these changes
Aug 16, 2018
| @@ -59,6 +59,7 @@ public int getPort() | |||
| return port; | |||
| } | |||
|
|
|||
| @JsonProperty | |||
There was a problem hiding this comment.
This missing JsonProperty looks a bug. Isn't it?
There was a problem hiding this comment.
I think it's not fixing any production bug, since the @JsonProperty on the connectURI field will get used if this one on the getter isn't there. In production that field is always going to be set. So I think this is technically a bug but it only affects test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think it's fixing any bug, but, I wrote the test anyway while investigating something else, and might as well commit it.