Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zstandard decompression support #6224

Merged
merged 1 commit into from
Aug 26, 2018
Merged

Zstandard decompression support #6224

merged 1 commit into from
Aug 26, 2018

Conversation

QiuMM
Copy link
Member

@QiuMM QiuMM commented Aug 23, 2018

Support decompression of files using Facebook's Zstandard(zstd) algorithm.

Copy link
Contributor

@gianm gianm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@himanshug
Copy link
Contributor

is license ( https://github.com/luben/zstd-jni/blob/master/LICENSE ) ok for apache ?

@gianm
Copy link
Contributor

gianm commented Aug 24, 2018

That looks like 2-clause BSD, which is ok (http://apache.org/legal/resolved.html#category-a). And zstd itself is 3-clause BSD, which is also ok.

@himanshug
Copy link
Contributor

LGTM then

@gianm gianm merged commit ef91fdb into apache:master Aug 26, 2018
@QiuMM QiuMM deleted the zstd branch September 20, 2018 16:13
@dclim dclim added this to the 0.13.0 milestone Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants