fix opentsdb emitter always be running and fail sending tags whose value contains colon #6251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-slim
reviewed
Aug 28, 2018
| |`druid.emitter.opentsdb.flushThreshold`|Queue flushing threshold.(Events will be sent as one batch)|no|100| | ||
| |`druid.emitter.opentsdb.maxQueueSize`|Maximum size of the queue used to buffer events.|no|1000| | ||
| |`druid.emitter.opentsdb.consumeDelay`|Queue consuming delay(in milliseconds).|no|10000| |
There was a problem hiding this comment.
can we add a short description about what this means like what happen if increased or decreased ? and maybe why 10second is a good default?
b-slim
reviewed
Aug 28, 2018
| @@ -40,28 +43,40 @@ | |||
| */ | |||
| private static final String PATH = "/api/put"; | |||
| private static final Logger log = new Logger(OpentsdbSender.class); | |||
| private static final long FLUSH_TIMEOUT = 60000; // default flush wait 1 min | |||
There was a problem hiding this comment.
does this means the emitter will block 1 min waiting for the flush to finish?
There was a problem hiding this comment.
Yes it is. This is learned from other emitter extensions, e.g graphite-emitter.
extensions-contrib/opentsdb-emitter/src/main/java/io/druid/emitter/opentsdb/OpentsdbSender.java
Outdated
Show resolved
Hide resolved
|
I have tested in my enviroment and worked fine. @b-slim can you help review this PR again, then we can end this as soon as possible. |
QiuMM
changed the title
jon-wei
approved these changes
Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6247 and #6292 . Opentsdb emitter extension was contributed by me, so I help fix these two issues.