Improve compaction tutorial to demonstrate compaction with keepSegmentGranularity = true #7079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tGranularity = true
clintropolis
approved these changes
Feb 15, 2019
| @@ -35,7 +36,7 @@ It will also be helpful to have finished [Tutorial: Loading a file](../tutorials | |||
|
|
|||
| ## Load the initial data | |||
|
|
|||
| For this tutorial, we'll be using the Wikipedia edits sample data, with an ingestion task spec that will create a separate segment for each hour in the input data. | |||
| For this tutorial, we'll be using the Wikipedia edits sample data, with an ingestion task spec that will create 1-3 segments per hour in the input data. | |||
There was a problem hiding this comment.
👍 for the link to segment sizing optimization above, but it would maybe also be worth mentioning that these settings are artificially constrained to produce extra segments so that the example data can be used for the compaction example. I don't think it's required though, so up to you if you modify this section.
There was a problem hiding this comment.
I think it makes sense. Will add.
|
Should the tutorial also link to the docs on setting up automatic compaction? |
jon-wei
pushed a commit
to jon-wei/druid
that referenced
this pull request
Feb 28, 2019
…tGranularity = true (apache#7079) * Improve compaction tutorial to demonstrate compaction with keepSegmentGranularity = true * typo * add a warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current tutorial demonstrates the compaction with
keepSegmentGranularity= false, but it's not recommended and a deprecated behavior. This PR changes it to whenkeepSegmentGranularity= true.