Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web console: Add some CSS to make long value copy even easier #7829

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

vogievetsky
Copy link
Contributor

@vogievetsky vogievetsky commented Jun 3, 2019

A small improvement on #7816 based on user testing.
Always show the copy button without having to scroll to it.

image

Also make it so that tslint is part of the tests (action-icon.spec.tsx was failing lint)

Copy link
Member

@clintropolis clintropolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

@fjy fjy merged commit 0de7983 into apache:master Jun 4, 2019
jihoonson pushed a commit to implydata/druid-public that referenced this pull request Jun 26, 2019
gianm pushed a commit to implydata/druid-public that referenced this pull request Jul 4, 2019
@clintropolis clintropolis added this to the 0.16.0 milestone Aug 8, 2019
@vogievetsky vogievetsky deleted the even-easier-value-copy branch September 22, 2019 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants