Adjust NOTICE files #7945
Adjust NOTICE files #7945
Conversation
There was a problem hiding this comment.
I think the commons-logging-1.1.1.jar entry could be removed, the three jars it mentions don't appear in our lib/ dependencies and from their pom.xml those jars are optional:
https://github.com/apache/commons-logging/blob/master/pom.xml#L452
| @@ -502,216 +293,9 @@ including, but not limited to: | |||
| - Apache Commons | |||
| - Apache Xerces | |||
|
|
|||
| ICU4J, (under analysis/icu) is licensed under an MIT styles license | |||
There was a problem hiding this comment.
In the Derby section above, I think we can remove the section pertaining to Lucene jars, I don't think we have those in the project
|
@jon-wei thanks, removed |
| Software Foundation and is distributed under the apache 2.0 | ||
| license. | ||
|
|
||
| The UnixCrypt.java code implements the one way cryptography used by |
There was a problem hiding this comment.
I think we have to keep this UnixCrypt part for jetty 6.1.26, these jars are bundled along with the hadoop-client 2.8.3 dependency
There was a problem hiding this comment.
correction, the jar that has UnixCrypt class is from druid-kerberos
druid-kerberos/jetty-6.1.26.jar
There was a problem hiding this comment.
Thanks, added. Also removed "Xerces2 Java Parser 2.9.1".
* Adjust NOTICE files * remove commons-logging * Remove lucene from derby * more adjustment
Adjust NOTICE files per comments at https://mail-archives.apache.org/mod_mbox/incubator-general/201906.mbox/%3CCAOGo0VZoqnNuMdBsbiPB1gzqdR_WAp8wyBx7jeANaKKkm6pavQ%40mail.gmail.com%3E.