Add druid.segmentCache.numBootstrapThreads back to the docs #8462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Travis integration test failure appears to be from a flaky test and needs to be retriggered. The documentation for |
|
I triggered the travis build. |
himanshug
approved these changes
Sep 4, 2019
clintropolis
pushed a commit
to clintropolis/druid
that referenced
this pull request
Sep 5, 2019
fjy
pushed a commit
that referenced
this pull request
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
druid.segmentCache.numBootstrapThreadswas removed from the documentation at some point. However, it is still used when set and I don't see any deprecation comments in the code, so I think it should be documented properly. I can imagine times when a user may want numBootstrapThreads and numLoadingThreads to be different. One specifically is when my team is okay with loading on more threads at startup than during post-startup when reaching out to HDFS deep store because we don't want to pound our production NameNode that has many tenants.Code link for referene
This PR has:
Key changed/added classes in this PR