Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance org.apache.dubbo.common.concurrent.CompletableFutureTaskTest#testCustomExecutor #2899

Closed
beiwei30 opened this issue Dec 6, 2018 · 1 comment · Fixed by #2904
Closed
Labels
help wanted Everything needs help from contributors

Comments

@beiwei30
Copy link
Member

beiwei30 commented Dec 6, 2018

org.apache.dubbo.common.concurrent.CompletableFutureTaskTest#testCustomExecutor need to enhance. Recently Traivs CI reports the following error:

org.apache.dubbo.common.logger.slf4j.Slf4jLoggerTest
testLocationAwareLogger(org.apache.dubbo.common.logger.slf4j.Slf4jLoggerTest)  Time elapsed: 0.251 sec  <<< ERROR!
org.mockito.exceptions.misusing.UnfinishedVerificationException: 

Missing method call for verify(mock) here:
-> at org.apache.dubbo.common.concurrent.CompletableFutureTaskTest.testCustomExecutor(CompletableFutureTaskTest.java:95)

Example of correct verification:
    verify(mock).doSomething()

Also, this error might show up because you verify either of: final/private/equals()/hashCode() methods.
Those methods *cannot* be stubbed/verified.
Mocking methods declared on non-public parent classes is not supported.

	at org.apache.dubbo.common.logger.slf4j.Slf4jLoggerTest.testLocationAwareLogger(Slf4jLoggerTest.java:34)
@beiwei30 beiwei30 added help wanted Everything needs help from contributors good first issue labels Dec 6, 2018
@beiwei30
Copy link
Member Author

beiwei30 commented Dec 7, 2018

@biyuhao will be on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Everything needs help from contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant