Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dubbo-config package hard coded value replacement for few java class #3100

Closed
2 tasks
khanimteyaz opened this issue Dec 29, 2018 · 2 comments
Closed
2 tasks

Comments

@khanimteyaz
Copy link
Contributor

Replace existing hard coded values for dubbo-config below classes

  • dubbo-common/src/main/java/org/apache/dubbo/common/Constants.java
  • dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractConfig.java
  • dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractInterfaceConfig.java
  • dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractMethodConfig.java
  • dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractReferenceConfig.java
  • dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ConsumerConfig.java

Along with hard coded value replacement have done small refactoring to use java stream and lambda.

  • I have searched the issues of this repository and believe that this is not a duplicate.
  • I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

  • Dubbo version: xxx
  • Operating System version: xxx
  • Java version: xxx

Steps to reproduce this issue

  1. xxx
  2. xxx
  3. xxx

Pls. provide [GitHub address] to reproduce this issue.

Expected Result

What do you expected from the above steps?

Actual Result

What actually happens?

If there is an exception, please attach the exception trace:

Just put your stack trace here!
@khanimteyaz
Copy link
Contributor Author

on it.

@zonghaishang
Copy link
Member

merged, close it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants