Fix #1411 Java Locale use '_' split language, country, variant. #1413
Conversation
|
|
|
杨浩 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
| private String language; | ||
| private String country; | ||
| private String variant; | ||
| private String value; |
There was a problem hiding this comment.
revert commit 0423219
线上环境需要LocaleHandler版本兼容，所以还原代码。
| @@ -68,7 +68,7 @@ public void writeObject(Object obj, AbstractHessianOutput out) | |||
| else { | |||
| Locale locale = (Locale) obj; | |||
|
|
|||
| out.writeObject(new LocaleHandle(locale.getLanguage(), locale.getCountry(), locale.getVariant())); | |||
| out.writeObject(new LocaleHandle(locale.toString())); | |||
There was a problem hiding this comment.
revert commit 0423219
线上环境需要LocaleHandler版本兼容，所以还原代码。
Codecov Report
@@ Coverage Diff @@
## master #1413 +/- ##
=========================================
+ Coverage 31.59% 31.6% +0.01%
=========================================
Files 682 682
Lines 33035 33048 +13
Branches 6592 6597 +5
=========================================
+ Hits 10436 10446 +10
- Misses 20748 20750 +2
- Partials 1851 1852 +1
Continue to review full report at Codecov.
|
|
let's merge this change, and consider how to improve it better. it doesn't have major impact anyway. |
see #1411
Java Locale.toString() split language, country and variant with char
\_.but not support the extentions, because of truncate
\_#.*in the commit.