Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Improve the annotation of LeastActiveLoadBalance #2893

Merged
merged 2 commits into from Dec 6, 2018

Conversation

HAO-zhuzi
Copy link
Contributor

What is the purpose of the change

#2884

Brief changelog

feat:Improve the annotation of LeastActiveLoadBalance

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@beiwei30 beiwei30 merged commit 63bf28d into apache:master Dec 6, 2018
@codecov-io
Copy link

Codecov Report

Merging #2893 into master will increase coverage by 0.01%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2893      +/-   ##
==========================================
+ Coverage   63.77%   63.79%   +0.01%     
==========================================
  Files         577      577              
  Lines       25926    25930       +4     
  Branches     4539     4540       +1     
==========================================
+ Hits        16534    16541       +7     
+ Misses       7242     7220      -22     
- Partials     2150     2169      +19
Impacted Files Coverage Δ
...pc/cluster/loadbalance/LeastActiveLoadBalance.java 88.23% <94.44%> (ø) ⬆️
...ng/exchange/support/header/HeartbeatTimerTask.java 73.68% <0%> (-15.79%) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 43.42% <0%> (-11.85%) ⬇️
...java/org/apache/dubbo/qos/command/impl/Online.java 75% <0%> (-8.34%) ⬇️
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 41.66% <0%> (-8.34%) ⬇️
...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java 83.33% <0%> (-5.56%) ⬇️
...ing/exchange/support/header/AbstractTimerTask.java 66.66% <0%> (-4.17%) ⬇️
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 54.21% <0%> (-3.62%) ⬇️
...c/main/java/org/apache/dubbo/rpc/RpcException.java 85.71% <0%> (-3.58%) ⬇️
...ache/dubbo/cache/support/expiring/ExpiringMap.java 40.35% <0%> (-1.76%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8af04d...cbe0cd5. Read the comment docs.

@beiwei30
Copy link
Member

beiwei30 commented Dec 6, 2018

I solved the conflict and merged it in.

@HAO-zhuzi
Copy link
Contributor Author

HAO-zhuzi commented Dec 10, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants