Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added Chinese translation for coding-standard. #102

Merged
merged 5 commits into from Jun 30, 2020
Merged

feat: added Chinese translation for coding-standard. #102

merged 5 commits into from Jun 30, 2020

Conversation

plainheart
Copy link
Member

@plainheart plainheart commented May 28, 2020

Chinese translation of coding-standard is currently missing, this PR provides the first version. Some reviews and suggestions are expected to make it better.
There are also some work to be done on https://github.com/ecomfe/echarts-www.
See apache/echarts-www#4

@plainheart
Copy link
Member Author

plainheart commented May 28, 2020

BTW, in current English version, in Statement block, comma , here should be semicolon ; ?

image

@pissang
Copy link
Contributor

pissang commented Jun 30, 2020

Hi @plainheart, sorry for the late reply. Indeed, it should be semicolon.

@pissang pissang requested a review from 100pah June 30, 2020 02:05
@pissang pissang merged commit 930099c into apache:master Jun 30, 2020
@Ovilia
Copy link
Contributor

Ovilia commented Jun 30, 2020

@plainheart Great job! Really appreciate it! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants