Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

candle chart issue with dataZoom.filterMode='none' #11010

Closed
topvis opened this issue Aug 13, 2019 · 4 comments · Fixed by #11529
Closed

candle chart issue with dataZoom.filterMode='none' #11010

topvis opened this issue Aug 13, 2019 · 4 comments · Fixed by #11529
Assignees
@pissang
Labels
bug difficulty: normal Issues that can be fixed with the average difficulty. en This issue is in English priority: high
Milestone
4.5.0

Comments

@topvis
Copy link

topvis commented Aug 13, 2019

Version

4.2.1

Reproduction link

https://jsfiddle.net/dapengliu/m4rpL2zo/5/

Steps to reproduce

Run the reproduction provided and zoom in the chart.

What is expected?

All the lines and candlesticks are displayed inside the chart area as expected.

What is actually happening?

All the lines are displayed inside the chart area as expected.
But some candlesticks are outside the chart area.

image
@echarts-bot
Copy link

echarts-bot bot commented Aug 13, 2019

Hi! We've received your issue and please be patient to get responded. 🎉
The average response time is expected to be within one day for weekdays.

In the meanwhile, please make sure that you have posted enough image to demo your request. You may also check out the API and chart option to get the answer.

Have a nice day! 🍵

@echarts-bot echarts-bot bot added bug en This issue is in English pending We are not sure about whether this is a bug/new feature. waiting-for-help labels Aug 13, 2019
@Ovilia Ovilia removed pending We are not sure about whether this is a bug/new feature. waiting-for-help labels Aug 15, 2019
@Ovilia Ovilia self-assigned this Aug 15, 2019
@Ovilia Ovilia removed their assignment Aug 30, 2019
@Ovilia Ovilia added difficulty: normal Issues that can be fixed with the average difficulty. priority: high labels Aug 30, 2019
@Ovilia Ovilia added this to the 4.5.0 milestone Sep 4, 2019
@topvis
Copy link
Author

topvis commented Sep 5, 2019 •
edited

@Ovilia I just want to add that this issue also exists on the vertical direction.
Here is the link to an updated reproduction of the issue where you can see the some candles are outside of the chart area on both horizontal and vertical directions.

image

@Ovilia
Copy link
Contributor

Ovilia commented Sep 5, 2019

@topvis Thanks for reporting.

@Ovilia Ovilia mentioned this issue Sep 5, 2019
Closed
@pissang pissang self-assigned this Sep 17, 2019
@pissang pissang mentioned this issue Sep 17, 2019
Closed
7 tasks
@pissang pissang mentioned this issue Oct 30, 2019
Merged
@pissang
Copy link
Contributor

pissang commented Oct 30, 2019

Add clip option in #11529 . Should fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pissang pissang

Labels
bug difficulty: normal Issues that can be fixed with the average difficulty. en This issue is in English priority: high
Projects
None yet
Milestone
4.5.0
Development

Successfully merging a pull request may close this issue.

feat(clip): candlestick add clip option apache/echarts
3 participants
@Ovilia @pissang @topvis