Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12672: polar data dim is radius #12679

Closed
wants to merge 3 commits into from
Closed

Conversation

susiwen8
Copy link
Contributor

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Correct visualMap get wrong data dimension under polar

Fixed issues

Close #12672

Details

Before: What was the problem?

Screen Shot 2020-05-21 at 13 42 59

After: How is it fixed in this PR?

Screen Shot 2020-05-21 at 13 38 59

Usage

Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@Ovilia
Copy link
Contributor

Ovilia commented Jun 18, 2020

I'm not sure about the way of fixing because it seems the same bug occurs with grid coordinate system.
@susiwen8 Can you check https://gallery.echartsjs.com/editor.html?c=xc80fFTT9a&v=1 to confirm?

@susiwen8
Copy link
Contributor Author

Ok, I'll check

@susiwen8 susiwen8 marked this pull request as draft June 18, 2020 05:32
@susiwen8 susiwen8 marked this pull request as ready for review June 20, 2020 10:11
@susiwen8
Copy link
Contributor Author

@Ovilia data dim is value dim, so find the right value axis would fix the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

极坐标系下渐变失效问题
2 participants