Optimize: disable tooltip transition at first show #13067
Conversation
|
Thanks for your contribution! |
| @@ -153,7 +151,7 @@ function assembleCssText(tooltipModel: Model<TooltipOption>) { | |||
| cssText.push('box-shadow:' + boxShadow); | |||
| // Animation transition. Do not animate when transitionDuration is 0. | |||
| // If tooltip show arrow, then disable transition | |||
| transitionDuration | |||
| !isFirstShow && transitionDuration | |||
| && !(['top', 'left', 'bottom', 'right'].includes(tooltipModel.get('position') as string)) | |||
| && tooltipModel.get('trigger') !== 'item' | |||
There was a problem hiding this comment.
Didn't notice it before. But we should use zrUtil.indexOf instead of includes here.
Also in the assembleArrow function also has includes usage. Which should be changed.
|
Hi @susiwen8. Just a suggestion that we should use more clear commits message. For example https://www.conventionalcommits.org/en/v1.0.0-beta.4/#summary It's not a good style to use a very general and unclear message like "Coorection base CR" |
Roger that 😛 |
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Brief Information
This pull request is in the type of:
What does this PR do?
The first time of showing
tooltipon each chart, because oftransition,tooltiprise from the bottom. So disable transition on the first timeFixed issues
Details
Before: What was the problem?
After: How is it fixed in this PR?
Usage
Are there any API changes?
Related test cases or examples to use the new APIs
NA.
Others
Merging options
Other information