Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ut #13438

Merged
merged 16 commits into from Oct 16, 2020
Merged

Fix ut #13438

merged 16 commits into from Oct 16, 2020

Conversation

100pah
Copy link
Member

@100pah 100pah commented Oct 15, 2020 •
edited

  • Change unit test: js -> ts
  • Change unit test code follow 5.0 modification.
  • Some bug fix and type fix detected by unit test.
  • Migrate echarts.??.ts files to src/.
  • Enable eslint in unit test and sort eslintrc.

@100pah
ts: rename ut file name from js to ts.
444bc08
@100pah
ts: (1) Migrate ut to ts (spec/data). (2) ix related typing in src.
e8e8bce
@100pah
fix: fix that throw error if only a few components mounted.
4d7f549
@100pah
ts: fix type of converters.
8b34dfb
@100pah
lint: sort eslint for both src, extension-src, test/ut
212f3cf
@100pah
fix: fix ut and fix getViusal bug brought by some of the 5.0 refactor.
9f69525
@100pah
test: remove unnecessary jsdom dependency (it cause some prepublish i…
199a49e 
…ssue). Use jest built-in jsdom.
@100pah
build: move /echarts.*.ts to src/echarts.*.ts . Otherwise if user imp…
0d47e96 
…ort from 'echarts.all', it might be confused whether echarts.all.ts or echarts.all.js
@100pah
test: fix ut: dataZoom
bed2ffc
@100pah
fix: fix dev fast entry since echarts.all.ts moved.
93ede9d
@100pah
fix: (1) clarify id and name type. (2) compat non supported name type.
81b2efe
@100pah
test: fix ut code to ts.
346cccd
@100pah
Merge branch 'next' into fix-ut
5499a90
@100pah
fix: add the missing entry file for echarts.*.ts migrate.
c5f4ef7
@100pah
fix: (1) fix series merge mapping (brought by some previous refactor …
7090bce 
…in 5.0). (2) tweak id name type and check.
@100pah
test: update ut for 5.0.
c6eecfe
@echarts-bot
Copy link

echarts-bot bot commented Oct 15, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@100pah 100pah merged commit 60664f9 into next Oct 16, 2020
@echarts-bot
Copy link

echarts-bot bot commented Oct 16, 2020

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang deleted the fix-ut branch October 11, 2021 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pissang pissang pissang approved these changes

Assignees
No one assigned
Labels
PR: author is committer size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@100pah @pissang