Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Use AbstractRetryer to unify GrpcRetryer, HttpRetryer and EventMeshTcpRetryer #4060

Closed
2 tasks done
pandaapo opened this issue Jun 1, 2023 · 0 comments · Fixed by #4061
Closed
2 tasks done
Labels
enhancement New feature or request

Comments

@pandaapo
Copy link
Contributor

pandaapo commented Jun 1, 2023

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

GrpcRetryer, HttpRetryer and EventMeshTcpRetryer all have these method pushRetry(), init(), shutdown() and start(). Althougth parameter type in pushRetry() is different. But the types here are in inheritance relationship.

And there are similar logic in size() and getRetrys().

Describe the solution you'd like

Add an parent class for GrpcRetryer, HttpRetryer and EventMeshTcpRetryer.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant