Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Correct eventmesh.properties comment grammar mistake #4185

Closed
2 tasks done
Pil0tXia opened this issue Jul 6, 2023 · 0 comments · Fixed by #4187
Closed
2 tasks done

[Doc] Correct eventmesh.properties comment grammar mistake #4185

Pil0tXia opened this issue Jul 6, 2023 · 0 comments · Fixed by #4187
Labels
documentation Improvements or additions to documentation

Comments

@Pil0tXia
Copy link
Member

Pil0tXia commented Jul 6, 2023 •
edited
Loading

Search before asking

  • I had searched in the issues and found no similar issues.

Documentation Related

image

According to the original Chinese comments in the git commit history, the existing English comments are misleading. The English translation does not match the meaning of the original Chinese text, which affects understanding.

Suggested Version:

    # Webhook CloudEvent sending mode. This property is the same as the eventMesh.storage.plugin.type configuration.
    producer:
      storage: standalone

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@Pil0tXia Pil0tXia added the documentation Improvements or additions to documentation label Jul 6, 2023
This was referenced Jul 6, 2023
Merged
Open
xwm1992 pushed a commit that referenced this issue Jul 10, 2023
@Pil0tXia
[ISSUE #4185] Correct eventmesh.properties comment grammar mistake (#…
1497fd3 
…4187)

* doc: Correct eventmesh.properties comment grammar mistake

* doc: Correct README.md grammar sequence mistake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #4185] Correct eventmesh.properties comment grammar mistake Pil0tXia/eventmesh
1 participant
@Pil0tXia