Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] eventmesh trace-zipkin plugin miss the properties #809

Closed
1 of 2 tasks
xwm1992 opened this issue Mar 12, 2022 · 0 comments
Closed
1 of 2 tasks

[Enhancement] eventmesh trace-zipkin plugin miss the properties #809

xwm1992 opened this issue Mar 12, 2022 · 0 comments
Assignees
@wqliang
Labels
enhancement New feature or request
Milestone
1.4.0

Comments

@xwm1992
Copy link
Contributor

xwm1992 commented Mar 12, 2022

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

gradle.properties file under the eventmesh-trace-zipkin plugin miss the pluginType and pluginName;
build.gradle file under the root project miss the eventmesh-trace-api

Describe the solution you'd like

please supply these missing properties

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@xwm1992 xwm1992 added the enhancement New feature or request label Mar 12, 2022
@wqliang wqliang added this to the 1.4.0 milestone Mar 12, 2022
@wqliang wqliang self-assigned this Mar 12, 2022
@wqliang wqliang mentioned this issue Mar 12, 2022
Merged
xwm1992 pushed a commit that referenced this issue Aug 4, 2022
@wqliang
Merge pull request #810 from wqliang/addTracePluginProperties
456e99c 
[ISSUE #809] add zipkin plugin properties

close #809
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wqliang wqliang

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.4.0
Development

No branches or pull requests
2 participants
@wqliang @xwm1992