Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contains never throw exception in method #92

Closed
walleliu1016 opened this issue Aug 7, 2020 · 0 comments
Closed

contains never throw exception in method #92

walleliu1016 opened this issue Aug 7, 2020 · 0 comments
Labels
improvement Improve the mechanism or performance

Comments

@walleliu1016
Copy link
Contributor

walleliu1016 commented Aug 7, 2020

method has catch the exception
public void sendResponse(ChannelHandlerContext ctx, DefaultFullHttpResponse response) { ctx.writeAndFlush(response).addListener(new ChannelFutureListener() { @Override public void operationComplete(ChannelFuture f) throws Exception { if (!f.isSuccess()) { httpLogger.warn("send response to [{}] fail, will close this channel", RemotingHelper.parseChannelRemoteAddr(f.channel())); f.channel().close(); return; } } }); }

@iNanos iNanos added the improvement Improve the mechanism or performance label Aug 19, 2020
@iNanos iNanos closed this as completed Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve the mechanism or performance
Projects
None yet
Development

No branches or pull requests

2 participants