Added notification module #178
Conversation
adhyans
force-pushed
the
notification
branch
2 times, most recently
from
00f925a
to
2f01e13
Compare
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-2.10-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-2.10-all.zip |
There was a problem hiding this comment.
why do we need this change?
| @@ -75,6 +75,15 @@ public static SearchParameters forClients(final String sqlSearch, final Long off | |||
| orderBy, sortOrder, staffId, accountNo, loanId, savingsId, orphansOnly, isSelfUser); | |||
| } | |||
|
|
|||
| public static SearchParameters forNotifications(final Integer offset, final Integer limit, | |||
There was a problem hiding this comment.
This new method is not required. You can use SearchParameters.forPagination(...) method
| @@ -167,6 +168,12 @@ protected void onSuccessfulAuthentication(HttpServletRequest request, | |||
| throws IOException { | |||
| super.onSuccessfulAuthentication(request, response, authResult); | |||
| AppUser user = (AppUser) authResult.getPrincipal(); | |||
|
|
|||
| if (notificationReadPlatformService.hasUnreadNotifications(user.getId())) { | |||
There was a problem hiding this comment.
Is notification module supported only for basicauth profile? Don't we support for oauth profile?
| import javax.ws.rs.core.UriInfo; | ||
|
|
||
| @Path("/notifications") | ||
| @Component |
There was a problem hiding this comment.
scope should be singleton
| @@ -39,5 +39,5 @@ INSERT INTO `stretchy_report_parameter` (`report_id`, `parameter_id`, `report_pa | |||
| INSERT INTO `stretchy_report_parameter` (`report_id`, `parameter_id`, `report_parameter_name`) VALUES | |||
| ((select sr.id from stretchy_report sr where sr.report_name='GeneralLedgerReport'), | |||
| (select sp.id from stretchy_parameter sp where sp.parameter_name='OfficeIdSelectOne'), | |||
| 'office'); | |||
| 'officeId'); | |||
There was a problem hiding this comment.
You should not modify the existing migration files
| @@ -45,13 +45,16 @@ | |||
| import org.apache.fineract.infrastructure.core.serialization.ApiRequestJsonSerializationSettings; | |||
There was a problem hiding this comment.
Listen to the business event and publish the notification event
| @@ -53,7 +53,9 @@ | |||
| import org.apache.fineract.infrastructure.core.serialization.ToApiJsonSerializer; | |||
There was a problem hiding this comment.
Listen to the business event and publish the notification event
| @@ -54,7 +54,9 @@ | |||
| import org.apache.fineract.infrastructure.core.serialization.ToApiJsonSerializer; | |||
There was a problem hiding this comment.
Listen to the business event and publish the notification event
| @@ -18,25 +18,6 @@ | |||
| */ | |||
| package org.apache.fineract.portfolio.client.api; | |||
There was a problem hiding this comment.
Listen to the business event and publish the notification event
| @@ -38,14 +38,18 @@ | |||
| import org.apache.fineract.infrastructure.core.serialization.ApiRequestJsonSerializationSettings; | |||
There was a problem hiding this comment.
Listen to the business event and publish the notification event
|
Can you please give more details why do we need to use spring-jms? |
|
I have used jms to publish the generated notifications to a queue(implmented via ActiveMq) and then used the jmslistener to subscribe to that queue and listen for any new notification. More specifically, jms with ActiveMq has been used to make the generation and reception of messages to be asynchronous. |
|
Have a look at how business events are implemented in Fineract. I believe the same way you can do it asynchronously by listening to required events. By this approach you no need to modify all API resources. |
|
I think I have followed the same design as the implementation of business events.
I have used only the publish method call from the API resources like Reasons why me and my mentor(Pranjal) decided to use an external queue :-
I think the only difference is that business event design uses a Map to store the list of published events and my implementation uses an external queue. |
|
You need to listen to the business events and you can push notifications in your message queue. API resourced should not have this changes. |
|
Okay, will do and get back to you.Thanks :) |
|
Hi Nazeer,
What I have currently refactored is like initiating the business events in the respective API resources and then listening to those business events. Is it good enough ? |
|
Have a look at current business events implementation. They won't be triggered from api resources. |
This module will allow developers to integrate notifications with their functionality. Here are some wikis on which you can read more about this module.