fixes #835 escaped binary data in collision logging #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctubbsii
reviewed
May 11, 2017
| @@ -96,6 +96,11 @@ private String encC(Map<Column, Bytes> ret) { | |||
| + "=" + enc(e.getValue()))); | |||
| } | |||
|
|
|||
| private String encMBC(Map<Bytes, Set<Column>> m) { | |||
There was a problem hiding this comment.
New private method with obfuscated name should have some comment describing what it's supposed to do.
There was a problem hiding this comment.
A better method name would help also. Maybe toEscapedString(...)
There was a problem hiding this comment.
I changed the method names. I didn't think comments were needed since the methods are private, have descriptive name, and are single line implementations.
|
|
||
| public static void increment(TransactionBase tx, Bytes row, Column col, int val) { | ||
| int prev = 0; | ||
| String prevStr = tx.get(row, col, ZERO).toString(); |
There was a problem hiding this comment.
Is it safe to call toString here on arbitrary bytes?
There was a problem hiding this comment.
I think its safe since its internal test code and we have full control over all of the code that calls it.
mikewalch
approved these changes
May 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.