fix(go/java): Enhance ASCII check in meta string encoding #1631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Mok <jjasonmok1@gmail.com>
jasonmokk
changed the title
Signed-off-by: Jason Mok <jjasonmok1@gmail.com>
Signed-off-by: Jason Mok <jjasonmok1@gmail.com>
Signed-off-by: Jason Mok <jjasonmok1@gmail.com>
Signed-off-by: Jason Mok <jjasonmok1@gmail.com>
LiangliangSui
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enhances the current ASCII check (before meta string encoding) I implemented in #1620 to return a UTF-8 encoded
MetaStringearly if the input is non-ASCII. This improves efficiency and saves time oncomputeEncodingandencode. Unit tests are also added.Related issues
#1619
Does this PR introduce any user-facing change?
Benchmark