Skip to content
This repository has been archived by the owner on Feb 8, 2019. It is now read-only.

fix #121 DataSourceProcessor and DataSinkProcessor default parallelism #13

Closed
wants to merge 1 commit into from

Conversation

darionyaphet
Copy link
Contributor

Set DataSourceProcessor and DataSinkProcessor's default parallelism value to 1.

When user startup a processor could don't set parallelism .

GEARPUMP-121

@whjiang
Copy link
Contributor

whjiang commented May 9, 2016

+1.

@manuzhang
Copy link
Contributor

+0. I think users should be aware of the parallelism of processors to run and I don't see the benefit this change brings. Meanwhile, it's inconsistent with the Processor API now.

@darionyaphet
Copy link
Contributor Author

@manuzhang When I using some processors to build a DAG , it's just to describe how to process the input stream , parallelism is the attribute of this processor . It should have a default value and one is suitable . thank you for you reply :)

@manuzhang
Copy link
Contributor

@darionyaphet IMO, users should know and take care of their parallelism so we'd better it explicit. They are free to add another layer with default value which make sense for their applications but we'd better assume nothing for them.

@huafengw
Copy link
Contributor

Hi, @darionyaphet please rebase your pr and I will merge it.

@codecov-io
Copy link

codecov-io commented May 19, 2016

Current coverage is 62.40%

Merging #13 into master will decrease coverage by 1.55%

  1. 2 files (not in diff) in ...rpump/cluster/master were modified. more
    • Misses +75
    • Hits -75
  2. 1 files (not in diff) in ...che/gearpump/cluster were modified. more
    • Misses +1
    • Hits -1
  3. 1 files (not in diff) in .../org/apache/gearpump were modified. more
    • Misses +8
    • Hits -8
  4. 2 files (not in diff) in ...apache/gearpump/util were modified. more
    • Misses +10
    • Hits -10
  5. 2 files (not in diff) in ...rpump/cluster/client were modified. more
    • Misses +1
    • Hits -1
  6. 2 files (not in diff) in ...che/gearpump/cluster were modified. more
  7. File ...ntStoreFactory.scala (not in diff) was modified. more
    • Misses -2
    • Partials 0
    • Hits +2
  8. File ...cutor/Executor.scala (not in diff) was modified. more
    • Misses -1
    • Partials 0
    • Hits +1
@@             master        #13   diff @@
==========================================
  Files           180        180          
  Lines          5950       5950          
  Methods        5671       5671          
  Messages          0          0          
  Branches        279        279          
==========================================
- Hits           3805       3713    -92   
- Misses         2145       2237    +92   
  Partials          0          0          

Sunburst

Powered by Codecov. Last updated by f6f8903...f3b2c17

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants