-
Notifications
You must be signed in to change notification settings - Fork 93
[GEARPUMP-268] Accept java.time.Instant in Message #142
Conversation
R: @huafengw |
@@ -37,7 +37,7 @@ class CountProcessor(taskContext: TaskContext, conf: UserConfig) | |||
} | |||
|
|||
override def processMessage(state: PersistentState[Int], message: Message): Unit = { | |||
state.update(message.timestamp, 1) | |||
state.update(message.timestamp.toEpochMilli, 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
message.timestamp.toEpochMilli == message.timeInMillis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but I propose to hide timeInMillis
from users in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's only used internally in Subscription
and can be replaced in the future as well.
Codecov Report@@ Coverage Diff @@
## master #142 +/- ##
==========================================
- Coverage 69.69% 69.66% -0.03%
==========================================
Files 191 191
Lines 6061 6069 +8
Branches 513 516 +3
==========================================
+ Hits 4224 4228 +4
- Misses 1837 1841 +4 Continue to review full report at Codecov.
|
travis has passed but not synced here somehow. Please check https://travis-ci.org/apache/incubator-gearpump/builds/199856894. Also, code coverage only runs when travis has passed. |
+1 |
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[GEARPUMP-<Jira issue #>] Meaningful description of pull request
sbt clean test
.