This repository has been archived by the owner on Feb 8, 2019. It is now read-only.
[GEARPUMP-359] Fix OutputWatermark advancing logic in Subscription #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
==========================================
- Coverage 69.16% 69.12% -0.05%
==========================================
Files 191 191
Lines 6123 6124 +1
Branches 357 362 +5
==========================================
- Hits 4235 4233 -2
- Misses 1888 1891 +3 |
manuzhang
reviewed
Oct 26, 2017
| @@ -209,7 +202,8 @@ class Subscription( | |||
| // to throttle the number of unacked AckRequest | |||
| incrementMessageCount(partition, ackOnceEveryMessageCount) | |||
| val targetTask = TaskId(processorId, partition) | |||
| val ackRequest = AckRequest(taskId, messageCount(partition), sessionId) | |||
| val processingWaterMark = publisher.getProcessingWatermark.toEpochMilli | |||
There was a problem hiding this comment.
nitpick: processingWaterMark => processingWatermark
|
LGTM. Merged with fixing the nitpick |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[GEARPUMP-<Jira issue #>] Meaningful description of pull requestsbt clean test.