This repository has been archived by the owner on Feb 8, 2019. It is now read-only.
fix GEARPUMP-143 add doc worker.executor-share-same-jvm-as-worker #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -89,3 +89,4 @@ This is the default configuration for `gear.conf`. | |||
| | gearpump.shared-thread-pool-dispatcher | default Dispatcher with "fork-join-executor" | default shared thread pool dispatcher | | |||
| | gearpump.single-thread-dispatcher | PinnedDispatcher | default single thread dispatcher | | |||
| | gearpump.serialization-framework | "org.apache.gearpump.serializer.FastKryoSerializationFramework" | Gearpump has built-in serialization framework using Kryo. Users are allowed to use a different serialization framework, like Protobuf. See `org.apache.gearpump.serializer.FastKryoSerializationFramework` to find how a custom serialization framework can be defined | | |||
| | worker.executor-share-same-jvm-as-worker | false | whether the executor actor is started in a seperate jvm(process) from which running the worker actor | | |||
There was a problem hiding this comment.
small typo "seperate". IMHO, "whether ... is started in the same JVM(process)" is more intuitive since the configuration is "share-same-jvm".
|
thanks for contribution. Some minor points. |
|
+1 |
|
@PipsqueakH merged to master. Do you have a jira id such that I can assign it to you ? |
manuzhang
pushed a commit
to manuzhang/incubator-gearpump
that referenced
this pull request
Jan 24, 2017
fix img link
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add deployment config doc