This repository has been archived by the owner on Feb 8, 2019. It is now read-only.
[GEARPUMP-192] refactor example sources task to use DataSourceAPI #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please modify the commit comment to the format "[GEARPUMP-XXX] xyz" |
|
also, please fix the UT failure |
Roshanson
changed the title
| override def onStart(startTime: Instant): Unit = { | ||
| self ! Watermark(Instant.now) | ||
| } | ||
| class Split() extends DataSource { |
There was a problem hiding this comment.
I prefer class Split extends DataSource, no braces.
Current coverage is 70.08% (diff: 100%)@@ master #78 diff @@
==========================================
Files 177 177
Lines 5927 5927
Methods 5604 5606 +2
Messages 0 0
Branches 323 321 -2
==========================================
+ Hits 4066 4154 +88
+ Misses 1861 1773 -88
Partials 0 0
|
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[GEARPUMP-192] Refactor example sources task to use DataSourceAPI.