GEODE-1617: Regions can be created with a variety of characters that … #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are unsupported Test for valid characters when creating non-internal regions
|
+1 This change causes Geode to enforce what the techpubs docs already say about Region names. |
|
Precheckin has lots of failures including in pivotal smoketests: https://jenkins.eng.pivotal.io/jenkins/job/GEM-patch-build-closed/342/#showFailuresLink |
|
Ok, good. The errors are "correct" because regions are being created with invalid names. I'll update the tests and determine which are internal regions. |
added 2 commits
July 12, 2016 15:16
…are unsupported Updated unit tests and added a new isInternalRegion field to InternalRegionAttributes
|
Closing this one until I can get the precheckin tests to pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…are unsupported
Test for valid characters when creating non-internal regions