GEODE-1548: Specifying --J=-Dgemfire.jmx-manager-hostname-for-clients… #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… now automatically sets -Djava.rmi.server.hostname
kirklund
reviewed
Sep 30, 2016
| import org.apache.geode.internal.AvailablePort; | ||
| import org.apache.geode.test.junit.categories.UnitTest; | ||
|
|
||
| @Category(UnitTest.class) |
There was a problem hiding this comment.
Since this test is testing more than one class (it's creating a Cache and using networking resources), it should have @category(IntegrationTest.class).
There was a problem hiding this comment.
The test name is ok but I'd probably make it JavaRmiServerNameIntegrationTest.java
There was a problem hiding this comment.
Isn't the convention to use *JUnitTest for unit tests?
There was a problem hiding this comment.
Oh got it, I missed the previous comment around @IntegrationTEST.
There was a problem hiding this comment.
Thanks for clarifying that distinction. I pushed another commit with this change.
kirklund
requested changes
Sep 30, 2016
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… now automatically sets -Djava.rmi.server.hostname