GEODE-1907: QueryDataFunction now adds LIMIT clause if space is missi… #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng after FROM clause
kirklund
requested changes
Sep 30, 2016
| if (regionMBean.getRegionType().equals(DataPolicy.PARTITION.toString()) || | ||
| regionMBean.getRegionType().equals(DataPolicy.PERSISTENT_PARTITION.toString())) { | ||
| return new JsonisedErroMessage(ManagementStrings.QUERY__MSG__JOIN_OP_EX.toLocalizedString()).toString(); | ||
| if (regionMBean.getRegionType() |
There was a problem hiding this comment.
I updated the formatters in etc/ including etc/intellijIdeaCodeStyle.xml to prevent these whacky linefeeds. Please update and rerun the formatter. The changes look good and I'll pull it in as soon as you've reformatted. Thanks!
There was a problem hiding this comment.
I reformatted with the updated code style and pushed again. Thanks!
…odeStyle.xml file.
|
+1 pulling in now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ng after FROM clause