New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/geode 2015 #267
Feature/geode 2015 #267
Conversation
This reverts commit d942321.
Changes look good. I think there needs to be some changes to geode-site/website/README.md to instruct people to build the docs and include them in the website though. Otherwise someone might build and push the website with the docs missing. |
Agreed. Working on that now. Thanks! |
Pulled & tested. I was especially concerned about the change in redirects from ../doc to ../guide. Local bookbinder bind works. Bookbinder 'watch', which worked for me before, throws errors from various Ruby gems. Not sure that support for bookbinder 'watch' is important, so maybe this doesn't matter. Sample of errors: $ bundle exec bookbinder watch Running middleman... == The Middleman is loading -- /Users/dbarnes/.rvm/gems/ruby-2.3.0/gems/middleman-core-4.1.10/lib/middleman-core/util/binary.rb:70:in `read' -- /Users/dbarnes/.rvm/gems/ruby-2.3.0/gems/middleman-core-4.1.10/lib/middleman-core/util/binary.rb:70:in `file_contents_include_binary_bytes?' -- /Users/dbarnes/.rvm/gems/ruby-2.3.0/gems/middleman-core-4.1.10/lib/middleman-core/util/binary.rb:38:in `binary?' -- /Users/dbarnes/.rvm/gems/ruby-2.3.0/gems/middleman-core-4.1.10/lib/middleman-core/sitemap/resource.rb:175:in `binary?' ...and so on. |
Correction - bookbinder watch did not work reliably for me, so this PR does not introduce a new problem. IMO, OK to accept this PR. |
+1 on this PR with two minor alterations in the
The correct commands are
Note: when merging in this PR to a current develop branch, there will be a conflict (as noted in the PR) on the subnav. Keep the develop branch's (new) link to the Automated Rebalance section, but update its path to include |
@karensmolermiller I committed a new README.md file with the two changes you suggested. My markdown editors showed the correct formatting before the changes, as well as after the changes. Please review to make sure they're registering in your markdown editor. |
Changes to docs and site directories for adding the documentation/user guide to the Geode website.