GEODE-2098: Moved gfsh history file location from .gemfire to .geode

[davinash]

Made the code changes and added a test for the same.

Following Test is failing with precheckin, but works fine when ran individually.
org.apache.geode.internal.statistics.DiskSpaceLimitIntegrationTest

[kirklund]

Since Geode 1.0 released using .gemfire history file, we should probably read and use .gemfire if .geode does not exist. If both files exist then .geode should take precedence.

What OS does DiskSpaceLimitIntegrationTest fail on for you?

[kirklund]

I recommend discussing backwards compatibility of .gemfire vs .geode directory (which contains gfsh history file) on the dev list. I don't really feel strongly one way or the other (supporting .gemfire vs just a hard switch to .geode). Dev list is good place to discuss backwards compatibility though.

[upthewaterspout]

IMO losing your gfsh history on an upgrade is probably not a big deal.

[metatype]

Agreed. This could be handled in a release note: “If you want to preserve your gfsh history, please copy…”

Anthony

On Nov 14, 2016, at 10:57 AM, Dan Smith notifications@github.com wrote:

IMO losing your gfsh history on an upgrade is probably not a big deal.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub #283 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/ACqT2dEBRv5RJyZjnBFGW1o76-yAooPwks5q-K7_gaJpZM4KxirC.

[davinash]

@kirklund
What OS does DiskSpaceLimitIntegrationTest fail on for you?
[ Avinash ] Linux

[davinash]

Thanks @kirklund @metatype @upthewaterspout. Do I need to mark the JIRA for release notes ? If not I will merge this PR, please let me know.

[kirklund]

+1 looks ready to push to develop.

Once it's committed on develop, then mark the Jira ticket Resolved (not Closed) and Fix Version(s) should say 1.1.0-incubating. When 1.1.0 is released, all Resolved tickets are moved to Closed (all such tickets will be part of release notes automatically I think).

[davinash]

Thanks @kirklund, @metatype I have followed the process from https://cwiki.apache.org/confluence/display/GEODE/Code+contributions
Please do let me know if everything is correct.

[kirklund]

I tried to pull this in but I get an error message about the branch not existing:

fatal: Couldn't find remote ref feature/GEODE-2098

Looks like the pull request is still open, but the branch has been destroyed.

[davinash]

closing the pull request.