GEODE-1617: Regions can be created with a variety of characters that … #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are unsupported Added comprehensive test to validate region names
|
+1 |
|
I reworded your commit message: |
kirklund
reviewed
Nov 15, 2016
| @@ -0,0 +1,75 @@ | |||
| package org.apache.geode.cache; | |||
There was a problem hiding this comment.
Missing the Apache license header on this file.
There was a problem hiding this comment.
Hmm, my local build didn't catch that and should have. Fixed.
kirklund
reviewed
Nov 15, 2016
| ira.setInternalRegion(false); | ||
| validateCharacters(ira); | ||
| try { | ||
| LocalRegion.validateRegionName("__InvalidInternalRegionName", ira); |
There was a problem hiding this comment.
Aren't you missing a fail() stmt here?
kirklund
requested changes
Nov 15, 2016
| } else { | ||
| try { | ||
| LocalRegion.validateRegionName(name, ira); | ||
| fail("Should have received an IllegalArgumentException"); |
There was a problem hiding this comment.
Recommend adding which character to the message so we get instant info about which character should have been illegal but was allowed.
There was a problem hiding this comment.
I added printing the offending character and the numeric value of it.
…are unsupported Added comprehensive test to validate region names
|
Pushed to develop. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…are unsupported
Added comprehensive test to validate region names