GEODE-2092: Security examples should not be in the product code #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinmeiliao
approved these changes
Nov 19, 2016
Moved examples to geode-core/src/main/java/org/apache/geode/examples/security/
Renamed them from Sample to Example (e.g., ExampleSecurityManager)
Deleted SimpleSecurityManager example class
Copied old Sample/Simple code to TestSecurityManager, TestPostProcessor and SimpleTestSecurityManager
|
@kjduling Is this ready to be merged? |
|
@metatype Yes, precheckin ran clean. |
|
I'll pull this in. |
PurelyApplied
pushed a commit
to PurelyApplied/geode
that referenced
this pull request
Mar 29, 2017
* Moved examples to geode-core/src/main/java/org/apache/geode/examples/security/ * Renamed them from Sample to Example (e.g., ExampleSecurityManager) * Copied old sample code to TestSecurityManager, SimpleTestSecurityManager, TestPostProcessor and SimpleTestSecurityManager * This closes apache#290 (cherry picked from commit 115a2f8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved examples to geode-core/src/main/java/org/apache/geode/examples/security/
Copied old Sample/Simple code to test packages as many tests rely on these classes.
Deleted SimpleSecurityManager example class