Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-268] Generate unique job name and job uri for GaaS #2121

Closed
wants to merge 2 commits into from

Conversation

yukuai518
Copy link
Contributor

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    Include source and destination in the job name.
    Include flow group and flow name in the job uri

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Run gobblin-service-deployable

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@yukuai518
Copy link
Contributor Author

@htran1 Can you take a look?

@yukuai518 yukuai518 changed the title [GOBBLIN-268] Generate uniqueue job name and job uri for GaaS [GOBBLIN-268] Generate unique job name and job uri for GaaS Sep 28, 2017
Copy link
Contributor

@htran1 htran1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.

@asfgit asfgit closed this in ae0ba28 Sep 28, 2017
zxliucmu pushed a commit to zxliucmu/incubator-gobblin that referenced this pull request Nov 16, 2017
@yukuai518 yukuai518 deleted the gaas_job branch January 15, 2018 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants