Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-280] Added new SpecCompiler compatible constructor to AzkabanSpecExecutor #2133

Closed
wants to merge 1 commit into from

Conversation

abti
Copy link
Member

@abti abti commented Oct 10, 2017

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    dd new SpecCompiler compatible constructor to AzkabanSpecExecutor since with MultiHop the SpecExecutor is invoked differently via reflection.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Trivial. Tested locally with Azkaban.

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@abti
Copy link
Member Author

abti commented Oct 10, 2017

Trivial. Self approving.

@asfgit asfgit closed this in 44738ed Oct 10, 2017
zxliucmu pushed a commit to zxliucmu/incubator-gobblin that referenced this pull request Nov 16, 2017
…nSpecExecutor

Closes apache#2133 from
abti/service_azkaban_orchestrator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant