Remove empty avro files during compaction #2158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@htran1 Can you review? |
htran1
reviewed
Nov 3, 2017
| this.eventSubmitter.submit(CompactionSlaEventHelper.COMPACTION_RECORD_COUNT_EVENT, eventMetadataMap); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private boolean isFailedPath(Path path, List<TaskCompletionEvent> failedEvents) { | ||
| return failedEvents.stream() | ||
| .filter(event -> path.toString().contains(event.getTaskAttemptId().toString())) |
There was a problem hiding this comment.
Only care about one match, so limit(1) can be added. Also, should put the path separator before and after the attempt id to avoid an incorrect match if the attempt id is a prefix of another attempt id. Like if attempt abc_10 passes, we don't want failed attempt abc_1 to match it.
htran1
suggested changes
Nov 3, 2017
| // remove all invalid empty files due to speculative task execution | ||
| List<TaskCompletionEvent> failedEvents = CompactionAvroJobConfigurator.getUnsuccessfulTaskCompletionEvent(job); | ||
| List<Path> allFilePaths = DatasetHelper.getApplicableFilePaths(this.tmpFs, this.dataset.outputTmpPath(), Lists.newArrayList("avro")); | ||
| List<Path> goodPaths = new ArrayList<>(); |
There was a problem hiding this comment.
This code shows up in CompactionCompleteFileOperationAction.java too. Can you make a common method for this?
| @@ -352,6 +370,11 @@ public void run() { | |||
| } | |||
| } | |||
|
|
|||
| private boolean isFailedPath(Path path, List<TaskCompletionEvent> failedEvents) { | |||
There was a problem hiding this comment.
This code is also in CompactionCompleteFileOperationAction.java.
zxliucmu
pushed a commit
to zxliucmu/incubator-gobblin
that referenced
this pull request
Nov 16, 2017
Closes apache#2158 from yukuai518/empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Remove all the files that was generated by a failed task attempt to avoid zero sized files.
Tests
No unit test changed
Commits