[GOBBLIN-328]Fix GobblinClusterKillTest failure. Path mismatch #2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: org.apache.gobblin.cluster.GobblinClusterKillTest failed because it looks at the wrong output path for the output files. Cause: It appears that the paths have changed. Fix: Update the path to match. Also: * Instead of disabling the tests. Move the tests to the group disabledOnTravis to continue to disable it on Travis until we have higher confidence with these tests. This makes it easier to run these tests locally. * Run the setup and teardown methods per method. This adds about 10s overhead per method. The worker kill test failed without this change when running with other tests. I suspect it is related to some state management issues. This change makes tests more self contained. * Some minor code quality improvements.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
org.apache.gobblin.cluster.GobblinClusterKillTest failed because it looks at the wrong output path for the output files.
Cause:
It appears that the paths have changed.
Fix:
Update the path to match.
Also:
Instead of disabling the tests. Move the tests to the group
disabledOnTravis to continue to disable it on Travis until we have
higher confidence with these tests.
This makes it easier to run these tests locally.
Run the setup and teardown methods per method. This adds about 10s
overhead per method.
The worker kill test failed without this change when running with other
tests. I suspect it is related to some state management issues.
This change makes tests more self contained.
Some minor code quality improvements.