[GOBBLIN-357] Fix logging during Zookeeper connection loss #2230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM +1 |
abti
approved these changes
Jan 5, 2018
kadaan
deleted the
GOBBLIN-357__Fix_poor_logging_when_zookeeper_connection_is_lost
branch
autumnust
pushed a commit
to autumnust/gobblin
that referenced
this pull request
Jan 9, 2018
Fix log messages when the zookeeper connection is lost which were not being formatted correctly. Add start & end log messages to job cancellation. Closes apache#2230 from kadaan/GOBBLIN-357__Fix_poor_log ging_when_zookeeper_connection_is_lost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@abti Feedback?
Fix log messages when the zookeeper connection is lost which were not being formatted correctly.
Add start & end log messages to job cancellation.