Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-461] disabling PasswordManagerTests as they fail often on travis #2332

Closed

Conversation

arjun4084346
Copy link
Contributor

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! @ibuenros please review

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    These tests were disabled before; but recently enabled again

57a6566#diff-ef5fa9697f5bdd44cfa577f2ed2b869aL36

and since then they fail often.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason: not needed as this is adding no new source code

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@asfgit asfgit closed this in 12bb1dc Apr 9, 2018
@arjun4084346 arjun4084346 deleted the disableDecryptionTests branch June 2, 2020 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant