[GOBBLIN-492] Refactor LoopingDatasetFinderSource to make it extensible #2363
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Some changes to make DeepIterator extensible and easily being overwritten by different implementation of iterators. They includes:
getWorkUnitIterator
method to be overwritten in subclass.doComputeNext
method to separate the logic of getting next available dataset object (Can be a dataset or a partition) fromDeepIterator
itself, so that different iterator that extends it can inherit the existing functionality of looping datasets, watermarks, etc. but have its own logic on how to fetch the next available dataset.JIRA
Description
Tests
Commits