Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GOBBLIN-612: Disable commit hash checkpointing for GitFlowGraphMonitor. #2478

Closed
wants to merge 1 commit into from

Conversation

sv2000
Copy link
Contributor

@sv2000 sv2000 commented Oct 12, 2018

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    We disable commit hash checkpointing for GitFlowGraphMonitor so that on service restart, it picks up all the commits from the beginning to correctly load the FlowGraph into memory.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Trivial change. Tested locally.

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@sv2000 sv2000 force-pushed the gitFlowGraphRestart branch 3 times, most recently from ce32b36 to 6d22cb2 Compare October 12, 2018 17:19
GOBBLIN-612: GOBBLIN-612: Disable commit hash checkpointing for GitFlowGraphMonitor.

GOBBLIN-612: Disable commit hash checkpointing for GitFlowGraphMonitor.

GOBBLIN-612: Disable commit hash checkpointing for GitFlowGraphMonitor.
Copy link
Contributor

@htran1 htran1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@asfgit asfgit closed this in 62c2d2d Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants