GOBBLIN-616: Add ability to fork jobs when concatenating Dags. #2483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htran1
suggested changes
Oct 22, 2018
| otherNode.addParentNode(node); | ||
| } | ||
| } else { | ||
| for (DagNode otherNode: other.startNodes) { |
There was a problem hiding this comment.
Can a parent of a forkable node also be forkable?
There was a problem hiding this comment.
No. Only nodes which are in the list of "endNodes" of a Dag are eligible for being forkable.
| //Append all the entries from the other dag's parentChildMap to this dag's parentChildMap | ||
| for (Map.Entry<DagNode, List<DagNode<T>>> entry: other.parentChildMap.entrySet()) { | ||
| for (Iterator<Map.Entry<DagNode, List<DagNode<T>>>> iterator = other.parentChildMap.entrySet().iterator(); |
|
Addressed the requested change. |
sv2000
pushed a commit
to sv2000/incubator-gobblin
that referenced
this pull request
Oct 23, 2018
Closes apache#2483 from sv2000/dependents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
We add the ability to fork jobs when concatenating 2 dags, as part of constructing a multi-hop path. An example use case is to allow retention jobs on each hop of the path to run in parallel to the distcp jobs along a multi-hop path, thus preventing the data copy on a subsequent hop from being blocked on a retention job on a previous hop.
Tests
Added test cases to DagTest and FlowGraphPathTest classes.
Commits