Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-680] Enhance error handling on task creation #2551

Closed
wants to merge 2 commits into from

Conversation

autumnust
Copy link
Contributor

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

In the process of creating Task object, especially in customized task execution framework, we usually see huge memory consumption in Task itself and it can run into OutOfMemoryError from time to time in one of our internal pipelines. OutOfMemoryError will not be caught by original implementation unfortunately since it is not an Exception. We added this implementation and corresponding testing code to make sure that, whenever there are virtual machine error like OutOfMemoryError happening, the countDownLatch is still being correctly handled.

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@autumnust
Copy link
Contributor Author

@ibuenros @htran1 @sv2000 can you help review ? Thanks.

Copy link
Contributor

@sv2000 sv2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@asfgit asfgit closed this in ff1f66c Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants