Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-703] Allow planning job to be running in non-blocking mode #2573

Closed
wants to merge 1 commit into from

Conversation

yukuai518
Copy link
Contributor

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    Today all the planning job will be running in a dedicated thread pool and will wait until the full execution to be completed. This requires a lot of system resources and a dedicated monitoring thread. The improvement here is to reduce the waiting time on a dedicated monitoring thread. Basically once the planning job submits to the Helix, we don't need to wait on the job completion. The job status monitoring will be achieved by GaaS monitoring.

By doing this, we are freeing most of the threadpool resources because each monitoring thread will be immediately return after it finishes the job submission.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@yukuai518
Copy link
Contributor Author

@htran1 could you help review?

Copy link
Contributor

@htran1 htran1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@asfgit asfgit closed this in 3e38ce3 Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants