Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-747]Check schema #2612

Closed
wants to merge 26 commits into from
Closed

Conversation

ZihanLi58
Copy link
Contributor

@ZihanLi58 ZihanLi58 commented Apr 22, 2019

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    Set the property of gobblin.copy.expectedSchema when creating the workunit to enable schema check in distcp.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Zihan Li and others added 24 commits March 21, 2019 16:32
@ZihanLi58
Copy link
Contributor Author

@ibuenros @autumnust Can you take a look at this?

@ZihanLi58 ZihanLi58 changed the title Check schema Check schema -- GOBBLIN-747 Apr 23, 2019
Copy link
Contributor

@ibuenros ibuenros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ZihanLi58 ZihanLi58 changed the title Check schema -- GOBBLIN-747 [GOBBLIN-747]Check schema Apr 23, 2019
@asfgit asfgit closed this in 6a725eb Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants