Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-763] Support fields removal for compaction dedup key schema #2627

Closed
wants to merge 2 commits into from

Conversation

zxcware
Copy link
Contributor

@zxcware zxcware commented May 2, 2019

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR:
  • Remove fields, specified by configuration compaction.job.key.fieldBlacklist, while computing compaction dedup key schema
  • Fix incorrect AvroUtils.removeUncomparableFields implementation, which only keeps the first field of any schema, dropping all other fields which have the same schema.

Tests

  • My PR adds the following unit tests:
  • CompactionJobConfiguratorTest.testKeyFieldBlacklist

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@zxcware
Copy link
Contributor Author

zxcware commented May 2, 2019

@yukuai518 @autumnust Please review.

@yukuai518
Copy link
Contributor

+1 LGTM

Copy link
Contributor

@htran1 htran1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@asfgit asfgit closed this in 8a9b5d0 May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants