Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gobblin-799]Fix bug in AvroSchemaCheckDefaultStrategy #2666

Closed
wants to merge 4 commits into from

Conversation

ZihanLi58
Copy link
Contributor

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    Add return statement to fix the bug.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Add unit test to test default schema check strategy.

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@ZihanLi58 ZihanLi58 changed the title Schema check bug [Gobblin-799]Schema check bug Jun 7, 2019
@ZihanLi58 ZihanLi58 changed the title [Gobblin-799]Schema check bug [Gobblin-799]Fix bug in AvroSchemaCheckDefaultStrategy Jun 7, 2019
@ZihanLi58
Copy link
Contributor Author

@ibuenros Can you take a look at this?

@asfgit asfgit closed this in 73cbd9f Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants