[GOBBLIN-813] Make SFDC connector support encrypted Salesforce client id and client secret #2677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yukuai518
suggested changes
Jun 25, 2019
| @@ -64,8 +64,10 @@ public SalesforceConnector(State state) { | |||
| @Override | |||
| public HttpEntity getAuthentication() throws RestApiConnectionException { | |||
| log.debug("Authenticating salesforce"); | |||
| String clientId = this.state.getProp(ConfigurationKeys.SOURCE_CONN_CLIENT_ID); | |||
| String clientSecret = this.state.getProp(ConfigurationKeys.SOURCE_CONN_CLIENT_SECRET); | |||
| String clientId = PasswordManager.getInstance(this.state) | |||
There was a problem hiding this comment.
Can we have this decryption logic configurable? So that not all the case we need this decyption. Today BDE team is also relying on this code base.
There was a problem hiding this comment.
Considering to reuse the same returned variable from PasswordManager.getInstance(this.state)
yukuai518
suggested changes
Jun 25, 2019
| @@ -64,8 +64,10 @@ public SalesforceConnector(State state) { | |||
| @Override | |||
| public HttpEntity getAuthentication() throws RestApiConnectionException { | |||
| log.debug("Authenticating salesforce"); | |||
| String clientId = this.state.getProp(ConfigurationKeys.SOURCE_CONN_CLIENT_ID); | |||
| String clientSecret = this.state.getProp(ConfigurationKeys.SOURCE_CONN_CLIENT_SECRET); | |||
| String clientId = PasswordManager.getInstance(this.state) | |||
There was a problem hiding this comment.
Considering to reuse the same returned variable from PasswordManager.getInstance(this.state)
haojiwu
changed the title
haojiwu
force-pushed
the
support_encrypted_salesforce_client_id_secret
branch
from
b911005
to
22fc2c3
Compare
haojiwu
changed the title
… id and client secret When reading client id and client secret from state properties, SalesforceConnector will use PasswordManager.readPassword() to decrypt it. This feature is controlled by source.conn.decrypt.client.id.secret and default is disabled
haojiwu
force-pushed
the
support_encrypted_salesforce_client_id_secret
branch
from
22fc2c3
to
5e4c27b
Compare
|
+1 LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading client id and client secret from state properties,
SalesforceConnector will use PasswordManager.readPassword() to decrypt
it.
readPassword() will check value to see if it is in encrypted pattern.
If not, the original value will be returned.
Therefore this changes can be backward compatible.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Tests
Commits